This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Update facebook-login sdk dep, add warning about facebook-common dep #1868
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the facebook-login android dependency to 11.+. There is no need to separately include facebook-core as it is a subdependency of facebook-login (see https://developers.facebook.com/docs/android/componentsdks & https://mvnrepository.com/artifact/com.facebook.android/facebook-login/11.3.0).
Importantly, the facebook-login version as been restricted to 11.+, as from 12.0.0, its subdependency facebook-common adds a dependency on androidx.fragment 1.3.0, overriding the @nativescript-android's expected ver 1.2.5, which breaks navigation in nested frames - minimal repro here: https://github.com/delaneyb/androidx-fragment-130-repro.