Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Added Android SDK conflict issues #811

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added Android SDK conflict issues #811

wants to merge 1 commit into from

Conversation

tomcatmwi
Copy link

Because this plugin rules, but compatibility issues suck!

Because this plugin rules, but compatibility issues suck!
@tomcatmwi tomcatmwi closed this Jul 22, 2018
@EddyVerbruggen
Copy link
Owner

Did you close this PR by accident?

@tomcatmwi
Copy link
Author

tomcatmwi commented Jul 22, 2018 via email

@EddyVerbruggen
Copy link
Owner

I understand, and I'd like to consider adding that change to this repo but for that to work, this PR (made from your fork) needs to be reopened 😃

@tomcatmwi tomcatmwi reopened this Jul 22, 2018
@tomcatmwi
Copy link
Author

Reopened.

@EddyVerbruggen
Copy link
Owner

Thanks!

By the way, before changing the file in the platforms/android folder, did you try applying those changes to this file as well?

@tomcatmwi
Copy link
Author

No, I didn't play with the demo. But before writing that readme segment I made a blank new HelloWorld app, added the plugin and registered it on Firebase. The steps I described have all been tested.

@EddyVerbruggen
Copy link
Owner

I understand, but I'm referring to changing the gradle file in the project source folder as opposed to the one in the build folder. That way you don't have to reapply those changes every time you remove the platforms/android folder. So if your suggested changes work just as well when changing the file I referred to, I'd rather suggest users to apply the changes there ;)

@tomcatmwi
Copy link
Author

I see. Yes, I tried, but NativeScript doesn't seem to give a damn. I guess the build.gradle file is generated only if it doesn't exist.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants