Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DMUL and DDIV overload #871

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

lupino3
Copy link
Member

@lupino3 lupino3 commented Nov 12, 2023

As a first step, simplify instruction building by using a dictionary rather than a giant switch statement.

Will fix #867.

@lupino3 lupino3 changed the title Add 2 new instructions Add DMUL and DDIV overload Nov 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2023

Codecov Report

Attention: Patch coverage is 98.13084% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.04%. Comparing base (f110e35) to head (abf2c2d).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #871      +/-   ##
============================================
- Coverage     52.18%   52.04%   -0.15%     
+ Complexity     1459     1394      -65     
============================================
  Files           251      251              
  Lines         10248    10147     -101     
  Branches       1104     1104              
============================================
- Hits           5348     5281      -67     
+ Misses         4580     4546      -34     
  Partials        320      320              
Files Coverage Δ
...java/org/edumips64/core/is/InstructionBuilder.java 98.37% <98.13%> (+14.44%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f110e35...abf2c2d. Read the comment docs.

@github-actions github-actions bot temporarily deployed to 871 November 13, 2023 08:59 Destroyed
@lupino3 lupino3 force-pushed the dev/lupino3/add-instructions branch from bb304ef to 90f9b6a Compare February 5, 2024 11:30
@github-actions github-actions bot temporarily deployed to 871 February 5, 2024 11:33 Destroyed
GWT 2.11 now supports Map.Entry.

This reverts commit 90f9b6a.
@github-actions github-actions bot temporarily deployed to 871 February 5, 2024 12:00 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DMUL rd, rs, rt and DDIV rd, rs, rt not implemented
2 participants