Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: nixpkgs input to the latest revision #334

Merged
merged 4 commits into from
Dec 19, 2024
Merged

nix: nixpkgs input to the latest revision #334

merged 4 commits into from
Dec 19, 2024

Conversation

YusukeShimizu
Copy link
Contributor

@YusukeShimizu YusukeShimizu commented Dec 16, 2024

This PR updates the following Nix packages:

  • cln to version v24.11
  • lnd to version v0.18.3-beta
  • bitcoin to version v28.0
  • elements to version v23.2.4

In addition, this PR includes adjustments for deprecated APIs in cln:

Note

After merging ElementsProject/glightning#21 and updating the module, the PR will be ready for review.

- cln v24.11
- lnd v0.18.3-beta
- bitcoin v28.0
- elements v23.2.4
- Refactor the BitcoinFallbackFromClnConfig function to use the new
  `configs` structure instead of `important-plugins`.
- https://docs.corelightning.org/reference/lightning-listconfigs
- Update glightning and other dependencies in go.mod and go.sum.
- Add error handling for empty peerId in SendMessage function.
- Add new test Test_ClnCln_Poll to verify poll execution.
- Ensure syncPoll error handling in clnclnSetupWithConfig.
@grubles
Copy link
Collaborator

grubles commented Dec 18, 2024

I've been running this PR on a node experiencing these error messages:

2024-12-16T00:31:03.814Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'

for a few hours now and have not seen any new ones occurring.

ACK 6d15ade

Update the version of github.com/elementsproject/glightning in go.mod
@YusukeShimizu YusukeShimizu marked this pull request as ready for review December 19, 2024 01:04
@YusukeShimizu
Copy link
Contributor Author

I removed the draft status.

@grubles
Copy link
Collaborator

grubles commented Dec 19, 2024

ACK b7e205c

@grubles grubles merged commit 9d41480 into master Dec 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLN deprecation/removal causes peerswap polls to not be sent to peers
2 participants