Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some function names in comment[skip ci] #353

Merged
merged 1 commit into from
Feb 12, 2025
Merged

chore: fix some function names in comment[skip ci] #353

merged 1 commit into from
Feb 12, 2025

Conversation

finaltrip
Copy link
Contributor

fix some function names in comment

@YusukeShimizu
Copy link
Contributor

Thanks for submitting your pull request.
The changes look good! However, could you please include [skip ci] (or [ci skip]) in the commit message so that our CI won’t run unnecessarily?

@finaltrip finaltrip changed the title chore: fix some function names in comment chore: fix some function names in comment[skip ci] Feb 12, 2025
@finaltrip
Copy link
Contributor Author

Thanks for submitting your pull request. The changes look good! However, could you please include [skip ci] (or [ci skip]) in the commit message so that our CI won’t run unnecessarily?

Of course.

Modified. Please review again.

YusukeShimizu
YusukeShimizu approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@YusukeShimizu YusukeShimizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your support!

@YusukeShimizu YusukeShimizu merged commit 63db0eb into ElementsProject:master Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YusukeShimizu YusukeShimizu YusukeShimizu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@finaltrip @YusukeShimizu