Remove hardcoded default user agent from touchscreen.py and static_browser.py #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minshallj
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to remove the hardcoded user_agents. @constantegonzalez found that it could be reported to internal security as an old browser, in some situations.
Made this a PR b/c not sure how important it is in the first place to change. But secondly, looks like lg_screenshot looks for a default user agent, in which case it might be better to simply update the user agent to something a bit more recent, even if it eventually gets "old" again.
No seeming issues running on the system when manually removing the user agent and running the touchscreen browser.