Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow set flags to be manipulate with add and sub keywords #425

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DarkArc
Copy link
Member

@DarkArc DarkArc commented Jan 15, 2020

This adds support for updating an existing region, so that if you have a long list of items in a set flag, such as deny-spawn you can add or remove items, rather than overwrite.

@DarkArc DarkArc force-pushed the feature/modifiable-set-flags branch from b574703 to a453f7e Compare January 15, 2020 03:45
This adds support for updating an existing region, so that
if you have a long list of items in a set flag, such as
`deny-spawn` you can add or remove items, rather than overwrite.

Example:
```
/rg flag test deny-spawn add creeper
/rg flag test deny-spawn remove zombie
```
@DarkArc DarkArc force-pushed the feature/modifiable-set-flags branch from a453f7e to c95f52a Compare January 15, 2020 03:56
@wizjany
Copy link
Collaborator

wizjany commented Mar 21, 2020

Think I would rather have a set syntax like + item,... and - item,... than the add/remove patterns. Works much better once we have piston set up with suggestions too, as +/- will appear at the top of the suggestion list before the possible values.

Also this should probably apply to MapFlag as well. Maybe we should abstract out AbstractCollectionFlag type?

@wizjany wizjany added this to the 7.1.0 milestone Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants