Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rules for BLAS.dot, BLAS.dotc, and BLAS.dotu #739
base: main
Are you sure you want to change the base?
Add rules for BLAS.dot, BLAS.dotc, and BLAS.dotu #739
Changes from all commits
b4bc4a7
eb96aaf
f0929d1
be409e4
86c9e8b
b5a7c85
9c1fd09
0a67b2d
851c240
fcac5c6
744e32e
846fe3a
6133de8
36c20ca
6edeb12
3707f08
b002e35
255f28c
9bac361
40ff30e
2130a26
b623cf0
fb91389
57b43ab
3f248cf
8e4ba1b
ced987e
d6443d3
7bb09f8
640169c
be426c2
627a5b1
f075240
87b217f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These utilities should be reusable for and greatly simplify the rules for all other Level 1 BLAS functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason calling the 2-arg
dot
, which forwards to the 5-argdot
, now errors withConst
return type:This is strange because only this line of code should be hit in this case, and all it does is call the primal function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 2-arg methods also error for reverse-mode. These are the only remaining failures in the test suite.
Edit: also, this only happens with
dot
and real inputs, not withdotc
ordotu
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open an issue?