Add tests for BLAS.dot, BLAS.dotc, and BLAS.dotu #842
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #842 +/- ##
==========================================
+ Coverage 78.03% 78.08% +0.04%
==========================================
Files 27 27
Lines 9148 9148
==========================================
+ Hits 7139 7143 +4
+ Misses 2009 2005 -4 ☔ View full report in Codecov by Sentry. |
|
Didn't intend to close, will merge it once I added coverage for dotu, dotc |
Also removes checks for consistency with 2-arg dot and pointer tests, since these should be covered by the base case.
|
I updated this PR to use EnzymeTestUtils. |
|
sgtm and still approved to merge (once tests pass). @ZuseZ4 was also wondering if you'd be able to add tests for some other BLAS functions as well. |
|
Sure, which ones? |
|
@ZuseZ4 mentioned gemv/gemm/scal/axpy/spmv also it looks like CI fails? |
I did implement scal, axpy, gemv, spmv, gemm, |
Pretty sure the failure is due to JuliaLang/Pkg.jl#1585. One way to workaround this is to not have a separate
Okay, I'll add this once I fix the CI |
|
thanks! Will try how tablegen does against the testcases tomorrow. |
Are the tablegen rules currently not being used? That could explain why when I added rules for |
* Add tests for BLAS rules * Make checks approximate * Fix approx check for tuples * Apply suggestion * Add EnzymeTestUtils as test dependency * Refactor to use EnzymeTestUtils Also removes checks for consistency with 2-arg dot and pointer tests, since these should be covered by the base case. * Make sure dev version of EnzymeTestUtils used in testing * Move blas.jl to test dir * Update path * Try to fix deving of EnzymeTestUtils * Dev EnzymeTestUtils while running tests * Remove EnzymeTestUtils as test dep * Load Pkg * Remove workaround in CI --------- Co-authored-by: William S. Moses <[email protected]>
As requested by @ZuseZ4, this PR just copies the tests from #739 but not the EnzymeRules.