Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added util for confirming service is not secure proxy #1654

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

abp6318
Copy link
Contributor

@abp6318 abp6318 commented Sep 18, 2024

  1. Description:
  1. Instructions for testing:
  1. Closes Issues: https://devtopia.esri.com/dc/hub/issues/11360

  2. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  3. used semantic commit messages

  4. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  5. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

@abp6318 abp6318 added the bug Something isn't working label Sep 18, 2024
@abp6318 abp6318 self-assigned this Sep 18, 2024
Copy link
Contributor

@sonofflynn89 sonofflynn89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Just a couple of minor things before we merge.

@abp6318 abp6318 merged commit f63927b into master Sep 18, 2024
5 checks passed
@abp6318 abp6318 deleted the b/11360-isSecureProxySeerviceUrl branch September 18, 2024 19:44
esri-dcdev-2 pushed a commit that referenced this pull request Sep 18, 2024
# @esri/hub-common [14.190.0](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2024-09-18)

### Bug Fixes

* added util for confirming service is not secure proxy ([#1654](#1654)) ([f63927b](f63927b))

### Features

* **hub-common:** add support to hubSearch for searching for events 3… ([#1648](#1648)) ([c31891e](c31891e))
Copy link
Member

@tomwayson tomwayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this have been feat instead of fix since you added a fn?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants