Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OTP-Manager general layout accessibility #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Badatos
Copy link

@Badatos Badatos commented Jan 27, 2025

Hello,
this is my first PR to improve the accessibility of OTP Manager.
It is based on the "master" branch but maybe you prefer that I base it on "develop"?
Do we need to talk in english or french here?
Feel free to specify if there are other contribution rules to respect.

Here are details about changes made :

  • Put "lang" value in "/" route
  • Replace #app.container div by main for more explicit client layout
  • Replace H2 by H1 in index.jade and H5 by P
  • put lang attribute in html tag for general layout

* Put "lang" value in "/" route
* Replace #app.container div by main for more explicit client layout
* Replace H2 by H1 in index.jade and H5 by P
* put lang attribute in html tag for general layout
@floriannari floriannari self-assigned this Jan 27, 2025
@Badatos
Copy link
Author

Badatos commented Jan 27, 2025

I also invite every web developer to install the "WAVE" plugin in your web browsers, to quickly have an overview of the critical accessibility points to correct.

https://wave.webaim.org/extension/

@floriannari
Copy link
Contributor

Bonjour et merci pour cette PR
(ainsi que pour celles que vous avez pu faire sur apereo-cas).

It is based on the "master" branch but maybe you prefer that I base it on "develop"?

C'est très bien sur "master" 👍

Do we need to talk in english or french here? Feel free to specify if there are other contribution rules to respect.

Je préfère en Français.
D'ailleurs en cas de besoin, vous pouvez aussi me contacter directement sur https://rocket.esup-portail.org/direct/florian.nari

Here are details about changes made :

* Put "lang" value in "/" route

* Replace #app.container div by main for more explicit client layout

* Replace H2 by H1 in index.jade and H5 by P

* put lang attribute in html tag for general layout

Effectivement on n'a pas vraiment pensé à l'accessibilité de la page "/" 😥

Je teste ça sur nos serveurs dans la semaine, mais ça m'a l'air nickel 👍

@Badatos
Copy link
Author

Badatos commented Jan 28, 2025

Bonjour et merci pour cette PR (ainsi que pour celles que vous avez pu faire sur apereo-cas).
C'est très bien sur "master" 👍
Je préfère en Français. D'ailleurs en cas de besoin, vous pouvez aussi me contacter directement sur https://rocket.esup-portail.org/direct/florian.nari

Effectivement on n'a pas vraiment pensé à l'accessibilité de la page "/" 😥
Je teste ça sur nos serveurs dans la semaine, mais ça m'a l'air nickel 👍

Bonjour Florian,
Va pour le français ! Je préfère aussi ;)
Ok, je continue donc mes tests en restant sur la branche Master.
En cas de souci, je passerai par RocketChat, merci.

Bonne journée !

floriannari pushed a commit that referenced this pull request Feb 20, 2025
This is a squash of multiples PR from Badatos

these PR improve :
- accessibility,
- compliance with typographical rules,
- formatting of certain files (e.g. removal of unnecessary spaces)

#42
Improve OTP-Manager general layout accessibility:

* Put "lang" value in "/" route
* Replace #app.container div by main for more explicit client layout
* Replace H2 by H1 in index.jade and H5 by P
* put lang attribute in html tag for general layout

#44
improved readme presentation
#45
* Increase duration of all toasted errors
* Replace some "b" html tags by "strongs"
* Use non breakable spaces in french strings punctuations
* Remove unwanted spaces in English strings (no spaces before punctuations in english)
* Display textual "language" on language icon
* CSS : add styles for heading (h1,2,3...)
* page-title now use H1 instead of p
* Correct some heading hierarchy
* Remove every `text-align: justify` (Avoid Justify align in every web pages for Accessibility)

#46
Display a disclosure triangle on accordion item "preferences", to better see it can be opened
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants