Cosmetic changes on Readme.md #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om being unintentionally pushed in git. + Adapt Readme.md to tell new users to clone default esup-dist.json on first installation
|
Bonjour, On ne voit pas les bénéfices car seuls 4 développeurs (tous à Paris 1) ont les droits d'accès au dépôt git. Et au pire ce seront uniquement les mots de passes de nos environnements de test qui pourraient être divulgués. Alors qu'en contrepartie :
|
|
OK, je modifie ma PR pour ne conserver que les changement cosmétiques du Readme du coup ;) |
floriannari
changed the title
esup.json as esup-dist.json
floriannari
pushed a commit
that referenced
this pull request
Feb 20, 2025
This is a squash of multiples PR from Badatos these PR improve : - accessibility, - compliance with typographical rules, - formatting of certain files (e.g. removal of unnecessary spaces) #42 Improve OTP-Manager general layout accessibility: * Put "lang" value in "/" route * Replace #app.container div by main for more explicit client layout * Replace H2 by H1 in index.jade and H5 by P * put lang attribute in html tag for general layout #44 improved readme presentation #45 * Increase duration of all toasted errors * Replace some "b" html tags by "strongs" * Use non breakable spaces in french strings punctuations * Remove unwanted spaces in English strings (no spaces before punctuations in english) * Display textual "language" on language icon * CSS : add styles for heading (h1,2,3...) * page-title now use H1 instead of p * Correct some heading hierarchy * Remove every `text-align: justify` (Avoid Justify align in every web pages for Accessibility) #46 Display a disclosure triangle on accordion item "preferences", to better see it can be opened
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renameesup.jsonasesup-dist.json, to prevent a configuration from being unintentionally pushed in git.+ Adapt Readme.md to tell new users to clone default esup-dist.json on first installation