-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mup: add Source Address to Type 1 ST Route #1193
Conversation
Very nice. Could I please ask for a separate test rather than extending the current one. |
Thank you for your work, if you can please update the PR with the suggested changes, I will then happily merge. |
@thomas-mangin san Thank you for your kind review!
What tests does this expect to add?I would like to know if you would like 🙏 |
You are welcome. The test you wrote is good but it is using an existing file. If you create a new configuration and test files instead, it keeps the new test separate. The configuration file needs to be created in etc/exabgp and a .ci and .msg file created in qa/encoding. qa/bin/functional can be used to run the new test. |
84de2bf
to
de4d280
Compare
thanks comment :) |
@thomas-mangin -san thanks for your review! 🙏 |
This patch adds Source Address to Type 1 ST Route as defined in draft-mpmz-bess-mup-safi-03.
See https://datatracker.ietf.org/doc/html/draft-mpmz-bess-mup-safi-03#section-3.1.3