Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DoozyX/clang-format-lint-action from 0.17 to 0.18 #3025

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 12, 2024

Bumps DoozyX/clang-format-lint-action from 0.17 to 0.18.

Release notes

Sourced from DoozyX/clang-format-lint-action's releases.

v0.18

Fix invalid escape sequence warning #67 Add clang-format 18 #70

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 12, 2024
@neheb
Copy link
Collaborator

neheb commented Aug 12, 2024

These clang-format changes are interesting to say the least. Some of them look like they won't conflict with older versions.

Having said that, this needs to be manually handled.

@neheb neheb force-pushed the dependabot/github_actions/DoozyX/clang-format-lint-action-0.18 branch 14 times, most recently from d41d7d2 to 4cea3cf Compare August 14, 2024 02:10
neheb and others added 3 commits August 14, 2024 14:41
This is preparation to add compatibility with previous versions.

Signed-off-by: Rosen Penev <[email protected]>
Bumps [DoozyX/clang-format-lint-action](https://github.com/doozyx/clang-format-lint-action) from 0.17 to 0.18.
- [Release notes](https://github.com/doozyx/clang-format-lint-action/releases)
- [Commits](DoozyX/clang-format-lint-action@v0.17...v0.18)

---
updated-dependencies:
- dependency-name: DoozyX/clang-format-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@neheb neheb force-pushed the dependabot/github_actions/DoozyX/clang-format-lint-action-0.18 branch from 4cea3cf to d26e6a0 Compare August 14, 2024 21:44
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 64.65%. Comparing base (77915ad) to head (d26e6a0).
Report is 36 commits behind head on main.

Files Patch % Lines
src/convert.cpp 0.00% 5 Missing ⚠️
src/tiffvisitor_int.cpp 0.00% 3 Missing ⚠️
src/basicio.cpp 0.00% 2 Missing ⚠️
src/bmffimage.cpp 50.00% 0 Missing and 1 partial ⚠️
src/pngchunk_int.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3025      +/-   ##
==========================================
+ Coverage   64.62%   64.65%   +0.03%     
==========================================
  Files         104      104              
  Lines       22239    22240       +1     
  Branches    10911    10911              
==========================================
+ Hits        14371    14379       +8     
+ Misses       5626     5616      -10     
- Partials     2242     2245       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neheb
Copy link
Collaborator

neheb commented Aug 14, 2024

Fixing the rest of these will be hard

Merging https://github.com/Exiv2/exiv2/ will make it easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant