-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Copilot with removed access can still edit profile details #57662
Open
nkdengineer
wants to merge
2
commits into
Expensify:main
Choose a base branch
from
nkdengineer:fix/51678-follow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+7
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,7 @@ import type {OnyxUpdateEvent, OnyxUpdatesFromServer, Request} from '@src/types/o | |
import type Response from '@src/types/onyx/Response'; | ||
import {isEmptyObject} from '@src/types/utils/EmptyObject'; | ||
import {queueOnyxUpdates} from './QueuedOnyxUpdates'; | ||
import {signOutAndRedirectToSignIn} from './Session'; | ||
|
||
// This key needs to be separate from ONYXKEYS.ONYX_UPDATES_FROM_SERVER so that it can be updated without triggering the callback when the server IDs are updated. If that | ||
// callback were triggered it would lead to duplicate processing of server updates. | ||
|
@@ -42,6 +43,12 @@ function applyHTTPSOnyxUpdates(request: Request, response: Response) { | |
if (response.jsonCode === 200 && request.successData) { | ||
return updateHandler(request.successData); | ||
} | ||
|
||
if (response.jsonCode === 408 && response.message?.includes('The account you are trying to use is deleted.')) { | ||
signOutAndRedirectToSignIn(true); | ||
return Promise.resolve(); | ||
} | ||
Comment on lines
+47
to
+50
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This does not belong to the onyx middleware. Let's write a new middleware for this flow. |
||
|
||
if (response.jsonCode !== 200 && request.failureData) { | ||
// 460 jsonCode in Expensify world means "admin required". | ||
// Typically, this would only happen if a user attempts an API command that requires policy admin access when they aren't an admin. | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as resolved.
Sorry, something went wrong.