Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
While doing some testing of this library I have found that the Example for web (run via
yarn web
) was broken because of wrong webpack config.I have no idea when it broke - it was like that before RN 75 migration and after it as well.
Btw @gedu did you try running it on your end when migrating to 75 here? #228 I wonder why it worked for you and not for me :/
Anyways on clean installs it did not work, and after I add this webpack config it does work.
Also a question - running
yarn install
on root level generates a yarn.lock file because it was missing. Was this on purpose?What this fixes
The error:
So I added a simple webpack loader accepting
.js
files.Checklist
Example
AppExample
App on all platforms:Screenshots/Videos