lib, zebra, pbrd, isisd, bgpd: fix static errors #17986
Open
+16
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnt += length; Signed-off-by: Dmytro Shytyi <[email protected]>
…inter
[HIGH] /build/make-pkg/output/_packages/cp-routing/src/zebra/rib.h:612:6: Access to field 'status' results in a dereference of a null pointer (loaded from variable 're') [core.NullDereference]
if (CHECK_FLAG(re->status, ROUTE_ENTRY_USE_FIB_NHG))
^
Found 1 defect(s) in rib.h
Signed-off-by: Dmytro Shytyi <[email protected]>
… null pointer (loaded from field 'neighbor') threeway_state = circuit->u.p2p.neighbor->threeway_state; Signed-off-by: Dmytro Shytyi <[email protected]>
va_end(msg->args); Signed-off-by: Dmytro Shytyi <[email protected]>
dmytroshytyi-6WIND
force-pushed
the
fix-static-30-01-2025
branch
from
6986fc2 to
5afea88
Compare
w->sects = calloc(sizeof(PyObject *), w->ehdr->e_shnum); Signed-off-by: Dmytro Shytyi <[email protected]>
dmytroshytyi-6WIND
force-pushed
the
fix-static-30-01-2025
branch
from
5afea88 to
b3ce0d2
Compare
…nc_ptr') if (*sid_wide_func_ptr == sid_wide_func) Signed-off-by: Dmytro Shytyi <[email protected]>
[HIGH] /build/make-pkg/output/_packages/cp-routing/src/lib/zlog.c:438:6: Access to field 'text' results in a dereference of a null pointer (loaded from variable 'msg') [core.NullDereference] if (msg->text && msg->text != stackbuf) Signed-off-by: Dmytro Shytyi <[email protected]>
dmytroshytyi-6WIND
force-pushed
the
fix-static-30-01-2025
branch
from
b3ce0d2 to
8216ca0
Compare
donaldsharp
reviewed
Feb 3, 2025
| @@ -598,6 +598,8 @@ DECLARE_HOOK(rib_shutdown, (struct route_node * rn), (rn)); | |||
| */ | |||
| static inline struct nexthop_group *rib_get_fib_nhg(struct route_entry *re) | |||
| { | |||
| if (re == NULL) | |||
There was a problem hiding this comment.
I would prefer that we figure out why a call to rib-get_fib_nhg is even possible with a null pointer instead of this fix
donaldsharp
reviewed
Feb 3, 2025
| @@ -1938,6 +1938,11 @@ int send_hello(struct isis_circuit *circuit, int level) | |||
| size_t len_pointer; | |||
| int retval; | |||
|
|
|||
| if (!circuit) { | |||
There was a problem hiding this comment.
again.. how is send_hello called with a null pointer?
donaldsharp
reviewed
Feb 3, 2025
| @@ -1211,7 +1211,8 @@ static bool alloc_srv6_sid_func_explicit(struct zebra_srv6_sid_block *block, | |||
| .func_allocated, | |||
| node, | |||
| sid_wide_func_ptr)) | |||
| if (*sid_wide_func_ptr == sid_wide_func) | |||
| if (sid_wide_func_ptr | |||
donaldsharp
reviewed
Feb 3, 2025
| @@ -3712,10 +3712,6 @@ static int bgp_capability_msg_parse(struct peer *peer, uint8_t *pnt, | |||
| zlog_err("%pBP: Capability length error", peer); | |||
| bgp_notify_send(peer->connection, BGP_NOTIFY_CEASE, | |||
| BGP_NOTIFY_SUBCODE_UNSPECIFIC); | |||
| /* | |||
There was a problem hiding this comment.
I originally left the pnt addition in because if we ever modified the code I wanted a reminder that the length pointer needed to be handled appropriately. Why are we removing this commented out code?
riw777
reviewed
Feb 4, 2025
There was a problem hiding this comment.
waiting on @donaldsharp 's comments ... I don't see anything beyond those right now
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a set of fixes related to static errors in lib, zebra, pbrd, isisd, bgpd.
Each commit provides a description of the error that was present before and is attempted to be corrected.