Bmp bgp open router id and as val #18037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
reviewed
Feb 6, 2025
pguibert6WIND
force-pushed
the
bmp_bgp_open_router_id_and_as_val
branch
from
caa9c57 to
1ba3845
Compare
ton31337
reviewed
Feb 7, 2025
| @@ -650,7 +651,7 @@ struct stream *bgp_open_make(struct peer *peer, uint16_t send_holdtime, as_t loc | |||
| stream_putw(s, (local_as <= BGP_AS_MAX) ? (uint16_t)local_as | |||
| : BGP_AS_TRANS); | |||
| stream_putw(s, send_holdtime); /* Hold Time */ | |||
| stream_put_in_addr(s, &peer->local_id); /* BGP Identifier */ | |||
There was a problem hiding this comment.
Using peer->bgp->router_id is not enough?
There was a problem hiding this comment.
bgp_open_make() API is also used to forge regular BGP open streams, and peer->local_id will need to be used. so I have to maintain this change.
pguibert6WIND
force-pushed
the
bmp_bgp_open_router_id_and_as_val
branch
from
1ba3845 to
7598721
Compare
When forging BMP open message, the BGP router-id of tx open message of the BMP LOC-RIB peer up message is always set to 0.0.0.0, whatever the configured value of 'bgp router-id'. Actually, when forging a peer up LOC-RIB message, the BGP router-id value should be taken from the main BGP instance, and not from the peer bgp identifier. Fix this by refreshing the router-id whenever a peer up loc-rib message should be sent. Signed-off-by: Philippe Guibert <[email protected]>
The transmitted AS value in te tx open message of the peer up loc-rib message is set to 0. Actually, it should reflect the AS value of the current BGP instance. Signed-off-by: Philippe Guibert <[email protected]>
pguibert6WIND
force-pushed
the
bmp_bgp_open_router_id_and_as_val
branch
from
7598721 to
323d8ed
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the value of router-id and AS value for BGP OPEN TX message made for LOC-RIB peerup/down messages.