Possible fix for NPE being thrown when sending resource-packs in the …

…configuration stage
FancyMcPlugins · Jan 5, 2025 · 513527d · 513527d
1 parent 1a3aa80
commit 513527d
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/main/java/de/oliver/fancyholograms/listeners/PlayerListener.java b/src/main/java/de/oliver/fancyholograms/listeners/PlayerListener.java
@@ -64,6 +64,10 @@ public void onWorldChange(@NotNull final PlayerChangedWorldEvent event) {
 
     @EventHandler(priority = EventPriority.MONITOR)
     public void onResourcePackStatus(@NotNull final PlayerResourcePackStatusEvent event) {
+        // Skipping event calls before player has fully loaded to the server.
+        // This should fix NPE due to vanillaPlayer.connection being null when sending resource-packs in the configuration stage.
+        if (!event.getPlayer().isOnline())
+            return;
         final UUID playerUniqueId = event.getPlayer().getUniqueId();
         final UUID packUniqueId = getResourcePackID(event);
         // Adding accepted resource-pack to the list of currently loading resource-packs for that player.