-
-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "can not" -> "cannot" #1338
base: 2.18
Are you sure you want to change the base?
Conversation
Changing the text of an exception can break user's code. In the real world, users do things like catch exceptions and try to parse the text. I'm not saying this is a good thing to do but it happens. |
100% agree with @pjfanning: I'm fine with changes to Javadocs, but let's not change exception messages for 2.x. So would it be possible to change this PR to only have Javadoc changes. |
Would be happy to apply just Javadoc changes... |
Applied Javadoc/comment-only changes to This cannot be done with rebase unfortunately, but if anyone wants to take a stab at that I'd be happy to review and merge. Leaving this PR open as reminder for now. |
Fixes various typos (mostly of
can not
->cannot
kind). Rationale is given in https://writingexplained.org/cannot-or-can-not-difference