Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3 - Preserve Markdown trailing whitespace #4

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

AramZS
Copy link
Contributor

@AramZS AramZS commented Feb 17, 2023

I was not aware that line-breaks were created with a double space at the end of a line. Very cool! Updated rules to preserve this technique.

Figured I'd also get ahead of potential YAML use and add rules to preserve its requirements as well.

Should resolve most of #3

@netlify
Copy link

netlify bot commented Feb 17, 2023

Deploy Preview for tftmap-massive-wiki ready!

Name Link
🔨 Latest commit 57238a2
🔍 Latest deploy log https://app.netlify.com/sites/tftmap-massive-wiki/deploys/63f67e8add21290008fb323a
😎 Deploy Preview https://deploy-preview-4--tftmap-massive-wiki.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@peterkaminski
Copy link
Contributor

@AramZS, I think the [*.{yaml,yml}] section won't work for our YAML, because YAML frontmatter is embedded in .md files.

(I'm guessing [*.{yaml,yml}] means "files with YAML extensions, right?)

WDYT?

@AramZS
Copy link
Contributor Author

AramZS commented Feb 21, 2023

@peterkaminski It depends on what editor the user is using! I have an additional configuration at the editor level that handles it, but not all users might. I'm fine switching it over to 2 spaces / tab (though that is not my personal preference), but we should be prepared to have some big changesets every time someone touches an older file, at least for a while until the editors' autofix smooth out all the changes.

@AramZS
Copy link
Contributor Author

AramZS commented Feb 22, 2023

As per the discussion, this is now two spaces === tab in markdown in order to support wide editor use and configuration using editorconfig.

@AramZS
Copy link
Contributor Author

AramZS commented Feb 22, 2023

See for most notable reference:

editorconfig/specification#38
editorconfig/editorconfig#323

Copy link
Contributor

@peterkaminski peterkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the consideration and research, Aram!

@peterkaminski peterkaminski merged commit 302c07b into Fellowship-of-the-Link:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants