Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Undefined BSON type #85

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jan 31, 2025

@AlekSi AlekSi requested review from Copilot, a team, chilagrow and noisersup January 31, 2025 14:17
@AlekSi AlekSi self-assigned this Jan 31, 2025
@AlekSi AlekSi added the code/feature Some user-visible feature is not implemented yet label Jan 31, 2025
@AlekSi AlekSi enabled auto-merge (squash) January 31, 2025 14:17

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • wirebson/testdata/all.hex: Language not supported
  • wirebson/decode.go: Evaluated as low risk
  • wirebson/encode.go: Evaluated as low risk
  • wirebson/size.go: Evaluated as low risk
Comments suppressed due to low confidence (1)

wirebson/logging.go:114

  • Returning an empty slog.Value for UndefinedType might be ambiguous. Consider returning a more meaningful value.
return slog.Value{}
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.38%. Comparing base (6f61731) to head (e116619).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   63.08%   63.38%   +0.29%     
==========================================
  Files          41       41              
  Lines        2395     2409      +14     
==========================================
+ Hits         1511     1527      +16     
+ Misses        700      698       -2     
  Partials      184      184              
Files with missing lines Coverage Δ
wirebson/bson.go 82.85% <100.00%> (+0.63%) ⬆️
wirebson/decode.go 92.20% <100.00%> (+2.59%) ⬆️
wirebson/encode.go 61.76% <100.00%> (+0.86%) ⬆️
wirebson/logging.go 92.44% <100.00%> (+0.13%) ⬆️
wirebson/size.go 96.42% <100.00%> (+0.13%) ⬆️
Flag Coverage Δ
test 63.38% <100.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make fuzzing happy 👍

@AlekSi AlekSi disabled auto-merge February 4, 2025 08:34
@AlekSi AlekSi merged commit 18e3c0b into FerretDB:main Feb 4, 2025
9 checks passed
@AlekSi AlekSi deleted the undefined branch February 4, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some user-visible feature is not implemented yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add support for Undefined BSON value
3 participants