fix(cd): it should behave correctly (#110)

.github/workflows/build.yml

@@ -11,33 +11,43 @@ jobs:
   build:
     name: Installing & Building
     runs-on: ubuntu-latest
-    if: "!contains(github.event.head_commit.message, '[skip ci]')"
+    permissions:
+      contents: write # to be able to publish a GitHub release
+      issues: write # to be able to comment on released issues
+      pull-requests: write # to be able to comment on released pull requests
+      id-token: write # to enable use of OIDC for npm provenance
     steps:
       - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
         with:
           fetch-depth: 0
+          persist-credentials: false # GITHUB_TOKEN must not be set for the semantic release
+          # https://github.com/semantic-release/semantic-release/blob/master/docs/recipes/ci-configurations/github-actions.md#pushing-packagejson-changes-to-your-repository
       - uses: actions/setup-node@v3
         with:
           node-version: 18.20.1
+
       - name: Install
         run: yarn
+
       - name: Lint, Test & Build on branch
         if: github.ref != 'refs/heads/main'
         run: npx nx affected --base=origin/main -t lint test build
+
       - name: Lint, Test & Build on main
         if: |
           github.event_name == 'push'
           && (
             github.ref == 'refs/heads/main'
           )
-        run: npx nx affected --base=HEAD~1 -t lint test build
+        run: npx nx affected --base=origin/main~1 --head=origin/main -t lint test build
+
       - name: Publish from main
         if: |
           github.event_name == 'push'
           && (
             github.ref == 'refs/heads/main'
           )
-        run: npx nx affected --base=HEAD~1 -t publish:package
+        run: npx nx affected --base=origin/main~1 --head=origin/main -t publish:package
         env:
           GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
           GIT_AUTHOR_EMAIL: ${{ secrets.GIT_AUTHOR_EMAIL }}

.releaserc.js

@@ -4,11 +4,19 @@ module.exports = {
   ],
   plugins: [
     [
-      '@semantic-release/exec',
+      '@semantic-release/commit-analyzer',
       {
-        analyzeCommitsCmd:  "../../commit-analyser.sh"
+        preset: 'angular',
+        releaseRules: [
+          // Example: `type(scope): subject [force release]`
+          { subject: '*\\[force release\\]*', release: 'patch' },
+          // Example: `type(scope): subject [force-release]`
+          { subject: '*\\[force-release\\]*', release: 'patch' },
+        ],
       },
     ],
+    '@semantic-release/release-notes-generator',
+    '@semantic-release/changelog',
     '@semantic-release/npm',
     [
       '@semantic-release/git',

package.json

@@ -5,6 +5,7 @@
   "scripts": {},
   "private": true,
   "devDependencies": {
+    "@semantic-release/changelog": "6.0.3",
     "@semantic-release/exec": "^6.0.3",
     "@semantic-release/git": "^10.0.1",
     "@types/jest": "^29.5.9",
@@ -22,7 +23,7 @@
     "nx": "15.9.2",
     "prettier": "^2.8.2",
     "prettier-eslint": "^15.0.1",
-    "semantic-release": "21.1.2",
+    "semantic-release": "22.0.12",
     "ts-jest": "^29.1.1",
     "ts-node": "^10.9.1",
     "typescript": "^5.0.4"

packages/agent-nodejs-testing/src/units/add-action.ts

@@ -59,6 +59,12 @@ export function getFormFieldValueAction<ReturnType>(
   action: TestableAction,
   label: string,
 ): (actionContext: ActionContext) => Promise<ReturnType> {
+  if (!action.definition.form) return null;
+
+  if (action.definition.form instanceof Function) {
+    throw new Error('Use getDynamicFormFieldValueAction function helper');
+  }
+
   return (
     getFormFieldAction(action, label) as {
       value: (actionContext: ActionContext) => Promise<ReturnType>;
@@ -71,6 +77,12 @@ export async function getDynamicFormFieldValueAction<ReturnType>(
   label: string,
   actionContext: ActionContext,
 ): Promise<(actionContext: ActionContext) => Promise<ReturnType>> {
+  if (!action.definition.form) return null;
+
+  if (!(action.definition.form instanceof Function)) {
+    throw new Error('Use getFormFieldValueAction function helper');
+  }
+
   return (
     (await getDynamicFormFieldAction(action, label, actionContext)) as {
       value: (actionContext: ActionContext) => Promise<ReturnType>;