Skip to content

Commit

Permalink
Refactoring for more consistent code
Browse files Browse the repository at this point in the history
  • Loading branch information
KuechA committed Feb 12, 2025
1 parent be0a767 commit 521dc9d
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 21 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,7 @@ class ForEachStatement : LoopStatement(), BranchingNode, StatementHolder {
@Relationship("VARIABLE")
var variableEdge =
astOptionalEdgeOf<Statement>(
onChanged = { _, new ->
val end = new?.end
if (end is HasAccess) {
end.access = AccessValues.WRITE
}
}
onChanged = { _, new -> (new?.end as? HasAccess)?.access = AccessValues.WRITE }
)

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,12 @@ class AssignExpression :
base = base.base as? MemberExpression
}

if (isSimpleAssignment) {
(end as? HasAccess)?.access = AccessValues.WRITE
} else {
(end as? HasAccess)?.access = AccessValues.READWRITE
}
(end as? HasAccess)?.access =
if (isSimpleAssignment) {
AccessValues.WRITE
} else {
AccessValues.READWRITE
}
}
)
var lhs by unwrapping(AssignExpression::lhsEdges)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,7 @@ class ComprehensionExpression : Expression(), ArgumentHolder {
var variableEdge =
astEdgeOf<Statement>(
of = ProblemExpression("Missing variableEdge in ${this::class}"),
onChanged = { _, new ->
val end = new?.end
if (end is HasAccess) {
end.access = AccessValues.WRITE
}
},
onChanged = { _, new -> (new?.end as? HasAccess)?.access = AccessValues.WRITE },
)

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,12 @@ class UnaryOperator : Expression(), HasOverloadedOperation, ArgumentHolder, HasT
var isPrefix = false

private fun changeExpressionAccess() {
var access = AccessValues.READ
if (operatorCode == "++" || operatorCode == "--") {
access = AccessValues.READWRITE
}
var access =
if (operatorCode == "++" || operatorCode == "--") {
AccessValues.READWRITE
} else {
AccessValues.READ
}
(input as? HasAccess)?.access = access
}

Expand Down

0 comments on commit 521dc9d

Please sign in to comment.