Making gradle build go (#359)

* Making gradle build go
Fraunhofer-AISEC · Mar 19, 2021 · 6be3678 · 6be3678
1 parent 699776f
commit 6be3678
Show file tree

Hide file tree

Showing 19 changed files with 22 additions and 5 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -26,9 +26,6 @@ jobs:
           fi
           echo "##[set-output name=version;]$VERSION"
         id: determine_version
-      - name: Build cpgo
-        run: |
-          cd go-jni && ./build.sh && sudo cp ../libcpgo.so /usr/lib/
       - name: Build ${{ steps.determine_version.outputs.version }}
         run: |
           if [ "$SONAR_TOKEN" != "" ]

diff --git a/README.md b/README.md
@@ -79,7 +79,7 @@ Some languages, such as Golang are marked as experimental and depend on other na
 
 #### Golang
 
-In the case of Golang, the necessary native code can be found in the `go-jni` folder. In order to build it you can use the `build.sh` script, which uses `java_home` to automatically find JNI headers and stores the finished library in the cpg root folder. This currently only works for Linux and macOS.
+In the case of Golang, the necessary native code can be found in the `src/main/golang` folder. Gradle should automatically find JNI headers and stores the finished library in the `src/main/golang` folder. This currently only works for Linux and macOS. In order to use it in an external project, the resulting library needs to be placed somewhere in `java.library.path`. 
 
 ## Development Setup
 

diff --git a/build.gradle.kts b/build.gradle.kts
@@ -191,3 +191,21 @@ spotless {
         googleJavaFormat()
     }
 }
+
+tasks.register("compileGolang") {
+    doLast {
+        project.exec {
+            commandLine("./build.sh")
+                .setStandardOutput(System.out)
+                .workingDir("src/main/golang")
+        }
+    }
+}
+
+tasks.named("compileJava") {
+    dependsOn(":compileGolang")
+}
+
+tasks.withType<Test> {
+    systemProperty("java.library.path", project.projectDir.resolve("src/main/golang"))
+}
diff --git a/go-jni/.vscode/tasks.json → src/main/golang/.vscode/tasks.json b/go-jni/.vscode/tasks.json → src/main/golang/.vscode/tasks.json
diff --git a/go-jni/basic_types.go → src/main/golang/basic_types.go b/go-jni/basic_types.go → src/main/golang/basic_types.go
diff --git a/go-jni/build.sh → src/main/golang/build.sh b/go-jni/build.sh → src/main/golang/build.sh
@@ -15,4 +15,4 @@ fi
 
 export CGO_CFLAGS="-I${JAVA_HOME}/include -I/${JAVA_HOME}/include/${ARCH}"
 
-go build -buildmode=c-shared -o ../libcpgo.${EXTENSION} lib/cpg/main.go
+go build -buildmode=c-shared -o libcpgo.${EXTENSION} lib/cpg/main.go
diff --git a/go-jni/declarations.go → src/main/golang/declarations.go b/go-jni/declarations.go → src/main/golang/declarations.go
diff --git a/go-jni/expressions.go → src/main/golang/expressions.go b/go-jni/expressions.go → src/main/golang/expressions.go
diff --git a/go-jni/frontend/frontend.go → src/main/golang/frontend/frontend.go b/go-jni/frontend/frontend.go → src/main/golang/frontend/frontend.go
diff --git a/go-jni/frontend/handler.go → src/main/golang/frontend/handler.go b/go-jni/frontend/handler.go → src/main/golang/frontend/handler.go
diff --git a/go-jni/go.mod → src/main/golang/go.mod b/go-jni/go.mod → src/main/golang/go.mod
diff --git a/go-jni/go.sum → src/main/golang/go.sum b/go-jni/go.sum → src/main/golang/go.sum
diff --git a/go-jni/language.go → src/main/golang/language.go b/go-jni/language.go → src/main/golang/language.go
diff --git a/go-jni/lib/cpg/main.go → src/main/golang/lib/cpg/main.go b/go-jni/lib/cpg/main.go → src/main/golang/lib/cpg/main.go
diff --git a/go-jni/node.go → src/main/golang/node.go b/go-jni/node.go → src/main/golang/node.go
diff --git a/go-jni/scope.go → src/main/golang/scope.go b/go-jni/scope.go → src/main/golang/scope.go
diff --git a/go-jni/statements.go → src/main/golang/statements.go b/go-jni/statements.go → src/main/golang/statements.go
diff --git a/go-jni/types.go → src/main/golang/types.go b/go-jni/types.go → src/main/golang/types.go
diff --git a/src/test/java/de/fraunhofer/aisec/cpg/frontends/golang/GoLanguageFrontendTest.kt b/src/test/java/de/fraunhofer/aisec/cpg/frontends/golang/GoLanguageFrontendTest.kt
@@ -387,6 +387,8 @@ class GoLanguageFrontendTest : BaseTest() {
         assertEquals("true", initializer.name)
 
         val `if` = body.statements[1] as? IfStatement
+
+        assertNotNull(`if`)
     }
 
     @Test
Original file line number	Diff line number	Diff line change
Expand Up		@@ -15,4 +15,4 @@ fi

		export CGO_CFLAGS="-I${JAVA_HOME}/include -I/${JAVA_HOME}/include/${ARCH}"

		go build -buildmode=c-shared -o ../libcpgo.${EXTENSION} lib/cpg/main.go
		go build -buildmode=c-shared -o libcpgo.${EXTENSION} lib/cpg/main.go
-Original file line number
+Diff line change
@@ Expand Up / @@ -387,6 +387,8 @@ class GoLanguageFrontendTest : BaseTest() { @@
             assertEquals("true", initializer.name)
             val `if` = body.statements[1] as? IfStatement
+            assertNotNull(`if`)
         }
         @Test
@@ Expand Down @@