Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle
InitializerListExpression
s as variables ofComprehensionExpression
s in the DFG #2016base: main
Are you sure you want to change the base?
Handle
InitializerListExpression
s as variables ofComprehensionExpression
s in the DFG #2016Changes from all commits
0f679a3
c5960a0
bfb31f6
7e8bdba
635bd02
9784925
7928575
3cdd91c
a3a4174
6d8b00b
8a8f0ea
44831ec
be0a767
521dc9d
18623e2
3da26d9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought. Wouldn't it make sense to just implements this on all
Expression
nodes? The memory overhead is probably negligible and we would remove a lot of uglyas? HasAccess
casts. Basically this should apply to all expressions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided against this because many
Expression
s cannot receive any data (i.e.,AccessValues.WRITE
never makes sense for them and for some, alsoREAD
might be confusing), so the access value is not useful there. Are the casts are a major concern? Any opinions on this @konradweiss ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But all of them (most?) are part of the DFG and it is interesting to have a harmonized way to access this information even for a lot of them it will statically stay with READ.