Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add casting for Finder. #342

Merged
merged 9 commits into from
Feb 26, 2024
Merged

Add casting for Finder. #342

merged 9 commits into from
Feb 26, 2024

Conversation

dereuromark
Copy link
Member

@dereuromark dereuromark commented Feb 24, 2024

With stricter method signatures this becomes necessary for Finder usage.

Resolves

We can release a new minor 7.1.0

@dereuromark dereuromark added this to the 7.x milestone Feb 24, 2024
This was linked to issues Feb 24, 2024
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.78%. Comparing base (27c0686) to head (c035154).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #342      +/-   ##
============================================
+ Coverage     90.65%   90.78%   +0.12%     
- Complexity      222      225       +3     
============================================
  Files            19       19              
  Lines           642      651       +9     
============================================
+ Hits            582      591       +9     
  Misses           60       60              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/Model/Filter/Finder.php Outdated Show resolved Hide resolved
@dereuromark
Copy link
Member Author

Adjusted as per feedback

src/Model/Filter/Finder.php Outdated Show resolved Hide resolved
@ADmad ADmad merged commit c75326b into master Feb 26, 2024
8 checks passed
@ADmad ADmad deleted the finder-cast branch February 26, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Casting needed for Finder filter 5.x: Search exception
2 participants