Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that affected entries are in order before comparing #198

Merged
merged 2 commits into from
Aug 19, 2023

Conversation

G-Rath
Copy link
Owner

@G-Rath G-Rath commented Jul 29, 2023

While the spec recommends that affected entries be sorted in order, it's not required and the comparison algorithm explicitly sorts affected before comparing.

I'd originally not done this because the databases generally being consumed by the detector do follow the recommendation and I didn't want the extra complexity but now that we have semantic this is very easy

@G-Rath G-Rath force-pushed the sort-osvs branch 2 times, most recently from e4a9d02 to fc2b50a Compare August 3, 2023 20:06
@G-Rath G-Rath added the bug Something isn't working label Aug 19, 2023
@G-Rath G-Rath merged commit e20e642 into main Aug 19, 2023
8 checks passed
@G-Rath G-Rath deleted the sort-osvs branch August 19, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant