-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remap upper stretched cube in #61
base: main
Are you sure you want to change the base?
remap upper stretched cube in #61
Conversation
correct typo
… and remapping options
…jiang/bill_remap_upper_stretched_cube_in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I believe, per @weiyuan-jiang, that this relies on updates in FVdycoreCubed_GridComp, so it should probably be undrafted when @sdrabenh undrafts all the other update PRs. |
Well its mix of all of these: |
Note for @weiyuan-jiang, @wmputman has an update for the milans on a branch: You can see the differences here: feature/wjiang/bill_remap_upper_stretched_cube_in...feature/wmputman/KM_v11_5_1_remap_upper I'm mainly talking about the MPI settings. I'm not too sure what the other changes are (QOS and Ostia). |
If we run our testing package all our tests will fail for upper restarts when compared to baseline. All tests are CF. @sdrabenh @wmputman who is best to help us with validation of upper restarts? Someone needs to confirm this is what we want to see. |
removed duplicate CHANGELOG entry (v12 bcs were added in a separate PR)
The branch is a merge of the branches feature/wmputman/remap_upper_stretched_cube_in and main. Testing is underway...