feat: reusable containers #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasschaub
force-pushed
the
reusable_containers
branch
from
65e70c8 to
d07e50a
Compare
matthiasschaub
force-pushed
the
reusable_containers
branch
2 times, most recently
from
44660f1 to
74c8df1
Compare
adresses testcontainers#109 Co-authored-by: Levi Szamek <[email protected]>
matthiasschaub
force-pushed
the
reusable_containers
branch
from
50e6160 to
e87e782
Compare
do not create Ryuk cleanup instance if reuse enabled and container has been start with `with_reuse`
🤖 I have created a release *beep* *boop* --- ## [4.9.1](testcontainers/testcontainers-python@testcontainers-v4.9.0...testcontainers-v4.9.1) (2025-01-21) ### Bug Fixes * milvus healthcheck: use correct requests errors ([testcontainers#759](testcontainers#759)) ([78b137c](testcontainers@78b137c)) * **mysql:** add dialect parameter instead of hardcoded mysql dialect ([testcontainers#739](testcontainers#739)) ([8d77bd3](testcontainers@8d77bd3)) * **tests:** replace dind-test direct docker usage with sdk ([testcontainers#750](testcontainers#750)) ([ace2a7d](testcontainers@ace2a7d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…estcontainers#769) When invoking `.start()` multiple times on the same `DockerContainer` instance, the call fails with `ValueError: The org.testcontainers namespace is reserved for internal use` error. Example code: ``` from testcontainers.core.container import DockerContainer container = DockerContainer("alpine:latest").with_kwargs(labels={}) container.start() container.stop() container.start() ``` The fix is to update labels for the container in a copy of the user-provided dictionary, so that: * the code doesn't mutate user structures * avoid side effects, allowing for multiple .start() invocations
Fixed a typo which I ran into while working a bugfix.
testcontainers#766) @alexanderankin We already discussed last year that we only want to support the latest Keycloak version. I added the `latest` tag to test parameterization so we get a better feedback for future Keycloak updates. Fixes testcontainers#764 --------- Co-authored-by: David Ankin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.