Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type aliases #130

Merged
merged 2 commits into from
Feb 21, 2025
Merged

fix: type aliases #130

merged 2 commits into from
Feb 21, 2025

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Feb 14, 2025

Fixes #129

@ldez ldez mentioned this pull request Feb 14, 2025
Closed
7 tasks
@ldez
Copy link
Contributor Author

ldez commented Feb 14, 2025

Friendly ping @xobotyi

@ldez ldez changed the title fix: aliases fix: type aliases Feb 14, 2025
@ldez
Copy link
Contributor Author

ldez commented Feb 21, 2025

@xobotyi PTAL

@ldez ldez mentioned this pull request Feb 21, 2025
Closed
xobotyi
xobotyi approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@xobotyi xobotyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise - lgtm

@xobotyi xobotyi merged commit c1fc709 into GaijinEntertainment:master Feb 21, 2025
8 checks passed
@ldez ldez deleted the fix/alias branch February 21, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xobotyi xobotyi xobotyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False negatives with Go 1.23
2 participants
@ldez @xobotyi