-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fastify docs #233
fastify docs #233
Conversation
👋 Your preview is ready! https://genezio-landing-page-pr-fe83aa71.app.genez.io/docs/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
docs/frameworks/fastifyjs.md
Outdated
import Tabs from '@theme/Tabs'; | ||
import TabItem from '@theme/TabItem'; | ||
|
||
# Fastify.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From their landing page[1] it doesn't seem that Fastify
has the suffix .js
.
I would remove .js
or js
terminations from this page to align with their branding.
docs/frameworks/fastifyjs.md
Outdated
|
||
# Deployment | ||
|
||
Learn how to deploy an existing Fastify.js app using Genezio, a serverless deployment platform that simplifies app management and reduces costs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Learn how to deploy an existing Fastify.js app using Genezio, a serverless deployment platform that simplifies app management and reduces costs | |
Learn how to deploy an existing Fastify.js app using Genezio, a serverless deployment platform that simplifies app management and reduces costs. |
docs/frameworks/fastifyjs.md
Outdated
<details> | ||
<summary>**Create a Hello World Fastify.js App**</summary> | ||
|
||
### 1. Initialize a New Node.js Project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### 1. Initialize a New Node.js Project | |
<h3> 1. Initialize a New Node.js Project </h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks a bit weird in the table of contents on the right side because docusaurus doesn't detect that this is an expandable section.
To fix this we should hide this headers from the ToC.
I researched a bit and we can do that by changing the markdown headers (###
) to html header tags.
Please to this change for all the headers in the expandable section.
docs/frameworks/fastifyjs.md
Outdated
# The compatibility of the function handler. | ||
type: aws |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# The compatibility of the function handler. | |
type: aws |
This field is not required and it might confuse the user. You can remove it.
docs/frameworks/fastifyjs.md
Outdated
``` | ||
|
||
:::info | ||
You need to deploy your environment variables single time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to deploy your environment variables single time. | |
You need to deploy your environment variables only once. |
docs/frameworks/fastifyjs.md
Outdated
|
||
### Do I Need to Modify My Fastify App Code? | ||
|
||
Your fastify code will only require the above [adjustments](#deployment-guide), as long as it is written in a **stateless** manner. [Read more](https://stackoverflow.com/questions/5329618/stateless-vs-stateful) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your fastify code will only require the above [adjustments](#deployment-guide), as long as it is written in a **stateless** manner. [Read more](https://stackoverflow.com/questions/5329618/stateless-vs-stateful) | |
Your Fastify project will only require the above [adjustments](#deployment-guide), as long as it is written in a **stateless** manner. To find out more about [stateless vs. stateful follow this link](https://stackoverflow.com/questions/5329618/stateless-vs-stateful). |
sidebars.js
Outdated
@@ -29,6 +29,7 @@ const sidebars = { | |||
"frameworks/expressjs", | |||
"frameworks/react-admin", | |||
"frameworks/refine", | |||
"frameworks/fastifyjs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"frameworks/fastifyjs", | |
"frameworks/fastify", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also be just fastify
without js.
docs/frameworks/fastifyjs.md
Outdated
|
||
Fastify.js is a popular Node.js web application framework that simplifies the development of server-side applications. It provides a robust set of features for building web servers and APIs. | ||
|
||
<!-- TODO: change to fastify template --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!-- TODO: change to fastify template --> |
👋 Your preview is ready! https://genezio-landing-page-pr-fe83aa71.app.genez.io/docs/ |
No description provided.