Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #200: Add XML file handler #202

Merged
merged 10 commits into from
Mar 7, 2024
Merged

Fixes #200: Add XML file handler #202

merged 10 commits into from
Mar 7, 2024

Conversation

mattiagiupponi
Copy link
Contributor

@mattiagiupponi mattiagiupponi commented Sep 12, 2023

Adding XML file handler

@mattiagiupponi mattiagiupponi self-assigned this Sep 12, 2023
@mattiagiupponi mattiagiupponi linked an issue Sep 12, 2023 that may be closed by this pull request
@mattiagiupponi mattiagiupponi marked this pull request as draft September 12, 2023 15:20
@mattiagiupponi mattiagiupponi marked this pull request as ready for review September 12, 2023 15:39
Copy link
Contributor

@giohappy giohappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattiagiupponi does #201 overrides this PR?

@mattiagiupponi
Copy link
Contributor Author

@giohappy yes, i open a PR for each handler to simply the changes

Copy link

gitguardian bot commented Feb 21, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
59204 Triggered Django Secret Key 718d6bf .env_test View secret
9468526 Triggered Generic Password 718d6bf entrypoint_test.sh View secret
9468526 Triggered Generic Password 718d6bf .env_test View secret
59204 Triggered Django Secret Key 6fde8c0 .env_test View secret
9468526 Triggered Generic Password 6fde8c0 entrypoint_test.sh View secret
9468526 Triggered Generic Password 6fde8c0 .env_test View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement XmlFilehandler
2 participants