Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 'develop' into 'stable' #1185

Merged
merged 47 commits into from
Feb 15, 2024
Merged

Merge 'develop' into 'stable' #1185

merged 47 commits into from
Feb 15, 2024

Conversation

benji-glitsos-ga
Copy link
Collaborator

Proposed changes

This PR includes:

  • Some link fixes
  • Some bullet point formatting fixes
  • Edited the README
  • Some code edits in one of the Tools python files
  • Editing the 'toctree' directives that are used by the Knowledge Hub to allow the Knowledge Hub to use subheadings within the sidebar.

Closes issues (optional)

Checklist

(Replace [ ] with [x] to check off)

  • Notebook created using the DEA-notebooks template
  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
  • If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with
  • Check for any spelling mistakes using the DEA Sandbox's built-in spellchecker (double click on markdown cells then right-click on pink highlighted words). For example:

sandbox_spellchecker

Benjamin Glitsos and others added 30 commits December 13, 2023 16:01
… they will open in a tab in the Jupyter Notebook
…toctree now, and replaced them with the sphinx-external-toc tableofcontents directive
…ea-docs toctree now, and replaced them with the sphinx-external-toc tableofcontents directive"

This reverts commit 04fb61c.
…evel-table-of-contents

Relegated responsibility of the top-level table of contents to the dea-docs repo instead
…use it is more important that this displays in a new tab properly in the Sandbox. Later I will try to fix this broken link on the dea-docs site
…ustralia/dea-notebooks into feature/fixing-links-jan-2024
* Add use_threads argument to parallel_apply

* Cleanup imports

* Update last modified date

* Add brief explanation of threads vs processes
* Update USAGE.rst

Add UNE course to courses list

* Update spellcheck_wordlist.txt

add 'automodule' to spellcheck word list and see if that helps
* Remove spellcheck action and replace with PR checklist item

* Upload image directly

* Delete .github/sandbox_spellchecker.jpg
Partially addresses #1167 
- add dea docs links
- partially make the dev stable bit a bit clearer
- update references to DEA Knowledge Hub from DEA User Guide
Add citation to usage.rst
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@robbibt robbibt merged commit ca20a30 into stable Feb 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants