Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update product and band names in ML notebook Machine_learning_with_ODC (#1276) #1278

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

jennaguffogg
Copy link
Collaborator

Proposed changes

Update product used in notebook to 'ga_ls8cls9c_gm_cyear_3' and update band references from 'red', 'blue' etc to 'nbart_red', 'nbart_blue'.

Checklist

(Replace [ ] with [x] to check off)

  • Remove any unused/empty code cells
  • Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
  • If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with
  • Check for any spelling mistakes using the DEA Sandbox's built-in spellchecker (double click on markdown cells then right-click on pink highlighted words). For example:

sandbox_spellchecker

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @jennaguffogg! There seems to be an issue with the tests at the moment; I think you can "Squash and merge" this even if they don't pass, as I don't think it's related to your changes

@JM-GA
Copy link
Collaborator

JM-GA commented Jan 17, 2025

Hi @jennaguffogg - looks like tests still failing on a connection issue to aws - I think the changes you have made are safe and good to merge into develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants