Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contour notebook to clarify what data is used #1290

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

robbibt
Copy link
Member

@robbibt robbibt commented Feb 27, 2025

Proposed changes

This notebook didn't need to have Sentinel-2C added, but it was missing a mention at the top of the notebook of the Sentinel-2 product that is currently used.

Closes issues (optional)

  • Closes Issue #000

Checklist

(Replace [ ] with [x] to check off)

  • Notebook created using the DEA-notebooks template
  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
  • If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with
  • Check for any spelling mistakes using the DEA Sandbox's built-in spellchecker (double click on markdown cells then right-click on pink highlighted words). For example:

sandbox_spellchecker

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@robbibt robbibt changed the base branch from develop to s2c_updates February 27, 2025 03:30
@BexDunn
Copy link
Collaborator

BexDunn commented Feb 27, 2025

looks like your testing suite is throwing some interesting errors @robbibt ? Should the tidal testing be running on this notebook?

@robbibt
Copy link
Member Author

robbibt commented Feb 27, 2025

looks like your testing suite is throwing some interesting errors @robbibt ? Should the tidal testing be running on this notebook?

Yeah, something is wrong with the tests. We currently run the entire DEA Tools test suite for every PR, but perhaps we don't need to... I think it's OK for now, and I'll do some tweaks before we merge s2c_updates is merged to develop

@robbibt
Copy link
Member Author

robbibt commented Feb 27, 2025

@BexDunn Can I please get a ✅? 🙏

Copy link
Collaborator

@erialC-P erialC-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tick :)

@erialC-P erialC-P merged commit 4336c90 into s2c_updates Feb 27, 2025
1 check failed
@erialC-P erialC-P deleted the update_contour branch February 27, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants