Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update satellite animations app to use Sentinel-2C #1296

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

LaurenSchenk1
Copy link
Collaborator

@LaurenSchenk1 LaurenSchenk1 commented Feb 27, 2025

Proposed changes

Update satellite animations app to use Sentinel-2C

Closes issues (optional)

  • Closes Issue #000

Checklist

(Replace [ ] with [x] to check off)

If this is a notebook, then have you:

  • Checked the structure of the notebook follows our DEA-notebooks template
  • Tested the notebook on the DEA Sandbox
  • Removed any unused Python packages from Load packages
  • Removed any unused/empty code cells
  • Removed any guidance cells (e.g. General advice)
  • Ensured that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Included relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Tested notebook on the DEA Sandbox
  • Cleared all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • If applicable, update the Notebook currently compatible with line below the notebook title to reflect the environments the notebook is compatible with
  • Check for any spelling mistakes using the DEA Sandbox's built-in spellchecker (double click on markdown cells then right-click on pink highlighted words). For example:

sandbox_spellchecker

⭐ Did you get stuck? This might help: https://github.com/GeoscienceAustralia/dea-notebooks/wiki/Create-a-DEA-Notebook

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@robbibt robbibt changed the base branch from develop to s2c_updates February 27, 2025 04:09
@erialC-P
Copy link
Collaborator

Is this PR still meant to be in draft?

@LaurenSchenk1
Copy link
Collaborator Author

it's ready to review now @erialC-P ! :)

Copy link
Collaborator

@erialC-P erialC-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in GitHub (ie not tested in the sandbox) but the changes all look good to me! Nice one!

@erialC-P erialC-P merged commit b4e327f into s2c_updates Feb 27, 2025
1 check failed
@erialC-P erialC-P deleted the generating_sat_animation branch February 27, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants