Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test suit to fix failures and improve setup #1299

Merged
merged 3 commits into from
Feb 28, 2025
Merged

Conversation

robbibt
Copy link
Member

@robbibt robbibt commented Feb 27, 2025

Proposed changes

Tide modelling functions in in Tools/dea_tools/coastal.py have been deprecated and moved to eo-tides, where they are now extensively tested (e.g. https://github.com/GeoscienceAustralia/eo-tides/tree/main/tests). Because of this, we can simplify our DEA Notebooks tests by removing these tests from the repo.

In addition, have updated our tests so that:

  • We no longer run DEA Tools tests on every PR. Instead, only modified notebooks are tested. This should make most PR tests much faster.
  • DEA Tools tests (as well as entire repo Notebooks tests) are now only run if DEA Tools Python files are modified. We need to test the entire repo because changes to DEA Tools could possibly affect any part of the repo.

@robbibt
Copy link
Member Author

robbibt commented Feb 28, 2025

These test failures are OK/expected - they indicate that our code will fail if run on the new experimental "latest" Sandbox image that @emmaai is working on. So we will need to fix some things before that image is eventually rolled out to the Sandbox - but that's months away! 🙂

image

Copy link
Collaborator

@erialC-P erialC-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work Robbi! Awesome changes to the repo testing schedule!!

@robbibt robbibt merged commit 51cdf16 into develop Feb 28, 2025
7 of 13 checks passed
@robbibt robbibt deleted the fix_tests branch February 28, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants