Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S2c updates jag #1301

Merged
merged 7 commits into from
Feb 28, 2025
Merged

S2c updates jag #1301

merged 7 commits into from
Feb 28, 2025

Conversation

jennaguffogg
Copy link
Collaborator

⭐ This is a template you can follow to help construct a good pull request!

Proposed changes

dea-notebooks/Real_world_examples/Turbidity_animated_timeseries.ipynb

  • updated markdown cells to include Sentinel 2C in addition to 2A and 2B
  • updated code cells to include 'ga_s2cm_ard_3', removed reference to 'both' Sentinels and replaced with 'the Sentinel-2 satellites'
  • updated tags and 'last modified' dates at end of notebook

dea-notebooks/DEA_products/DEA_Sentinel2_Surface_Reflectance.ipynb

  • updated markdown cells to include Sentinel 2C in addition to 2A and 2B
  • updated code cells to include 'ga_s2cm_ard_3'
  • updated tags and 'last modified' dates at end of notebook

Checklist

(Replace [ ] with [x] to check off)

If this is a notebook, then have you:

  • Checked the structure of the notebook follows our DEA-notebooks template
  • Ensured that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Included relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Tested notebook on the DEA Sandbox
  • Cleared all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • If applicable, update the Notebook currently compatible with line below the notebook title to reflect the environments the notebook is compatible with
  • Check for any spelling mistakes using the DEA Sandbox's built-in spellchecker (double click on markdown cells then right-click on pink highlighted words). For example:

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

core.5902 Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this accidently commited? Might need to delete and then commit/push the change

Copy link
Collaborator Author

@jennaguffogg jennaguffogg Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted the file and committed again, also changed the base to the correct branch s2c_updates instead of develop

@jennaguffogg jennaguffogg changed the base branch from develop to s2c_updates February 27, 2025 22:07
@jennaguffogg jennaguffogg reopened this Feb 27, 2025
@robbibt robbibt self-requested a review February 27, 2025 22:56
Copy link
Member

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jennaguffogg - feel free to "squash and merge"!

@robbibt robbibt merged commit 6127db6 into s2c_updates Feb 28, 2025
@robbibt robbibt deleted the s2c_updates_jag branch February 28, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants