-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update polygonise pixel edges notebook to use S2C #1302
Conversation
Updated the template with some additional links and info and to de-prioritise testing on the NCI
removed duplicate checkbox
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @biancafichera! There was a small merge conflict caused by a change to develop
branch that happened between you starting your changes and committing them... I think I've fixed it. All good to merge by selecting "Squash and merge" when you're ready!
@BexDunn did you mean to commit changes to the PR_Template into this branch? ;) |
Also reviewed and it looks awesome @biancafichera !! |
Thanks guys @robbibt and @erialC-P ! |
⭐ This is a template you can follow to help construct a good pull request!
Proposed changes
See title.
Closes issues (optional)
Checklist
(Replace
[ ]
with[x]
to check off)If this is a notebook, then have you:
Load packages
General advice
)jupyterlab_code_formatter
tool can be used to format code cells to a consistent style: select each code cell, then clickEdit
and then one of theApply X Formatter
options (YAPF
orBlack
are recommended).Notebook currently compatible with
line below the notebook title to reflect the environments the notebook is compatible with⭐ Did you get stuck? This might help: https://github.com/GeoscienceAustralia/dea-notebooks/wiki/Create-a-DEA-Notebook