Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update polygonise pixel edges notebook to use S2C #1302

Merged
merged 4 commits into from
Feb 27, 2025

Conversation

biancafichera
Copy link
Collaborator

@biancafichera biancafichera commented Feb 27, 2025

⭐ This is a template you can follow to help construct a good pull request!

Proposed changes

See title.

Closes issues (optional)

  • Closes Issue #000

Checklist

(Replace [ ] with [x] to check off)

If this is a notebook, then have you:

  • Checked the structure of the notebook follows our DEA-notebooks template
  • Removed any unused Python packages from Load packages
  • Removed any unused/empty code cells
  • Removed any guidance cells (e.g. General advice)
  • Ensured that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Included relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Tested notebook on the DEA Sandbox
  • Cleared all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • If applicable, update the Notebook currently compatible with line below the notebook title to reflect the environments the notebook is compatible with
  • Check for any spelling mistakes using the DEA Sandbox's built-in spellchecker (double click on markdown cells then right-click on pink highlighted words). For example:

sandbox_spellchecker

⭐ Did you get stuck? This might help: https://github.com/GeoscienceAustralia/dea-notebooks/wiki/Create-a-DEA-Notebook

BexDunn and others added 3 commits February 27, 2025 14:19
Updated the template with some additional links  and info and to de-prioritise testing on the NCI
removed duplicate checkbox
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@biancafichera biancafichera changed the base branch from develop to s2c_updates February 27, 2025 05:22
Copy link
Member

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @biancafichera! There was a small merge conflict caused by a change to develop branch that happened between you starting your changes and committing them... I think I've fixed it. All good to merge by selecting "Squash and merge" when you're ready!

@erialC-P
Copy link
Collaborator

@BexDunn did you mean to commit changes to the PR_Template into this branch? ;)

@erialC-P
Copy link
Collaborator

Also reviewed and it looks awesome @biancafichera !!

@biancafichera
Copy link
Collaborator Author

Thanks guys @robbibt and @erialC-P !
@robbibt Sorry about that, I had a few people helping me go through it, but we missed the step where you change the base branch to s2c_updates, but we were assured that if we edit and change it it shouldn't be an issue! I do hope it didn't cause much of an issue for you! I'll 'Squash and merge' now :)

@biancafichera biancafichera merged commit 9a04db1 into s2c_updates Feb 27, 2025
@biancafichera biancafichera deleted the update_poly_pixel_edge branch February 27, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants