-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix for shapefile reader #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
track.ncReadTrackData previously returned cftime.DatetimeGregorian objects, which caused newer versions of matplotlib.dates.num2date to fail. This is because we write the tracks with units of 'hours since 1900-01-01 00:00', but matplotlib.dates uses 1970-01-01 as the epoch, and works in units of days (with no way to specify units in the num2date function).
* Update README.rst * Update version number * Merge commit 'ea8e3b816cf01089a304e121669880ef193c4b23' * Read netcdf-format track file from GA SST GA's Scenario selection tool allows users to download a selected track file, but due to technical constraints this is in a different format. This change allows TCRM to read the modified format. * Fix up a couple of tests that were failing * Bugfix: getPoci returns np.nan incorrectly * Create tcrm-tests.yml for github actions
Remove `fail-under` threshold
* Add script to run through all permutations of wind parameters
* NHIRS-148: Using queue instead of massive number of threads. * NHIRS-148: Re-organised imports. * NHIRS-148: Added logging * NHIRS-148: Removed unnecessary usage of threading. * NHIRS-148: FlushCache added on each 1% progress and at the end. Co-authored-by: Craig Arthur <[email protected]> Co-authored-by: Craig Arthur <[email protected]>
* Updated rmax to linear formula Co-authored-by: Craig Arthur <[email protected]>
This PR implements several functions in fortran with MPI parallelisation: - the Holland profile vorticity, velocity, and pressure profile - the Kepert wind field model - the conversion from latitude and longitude to polar coordinates This yields a total speedup of 5x when calculating wind fields and potentially more if the wind fields at each time step are not saved.
* handle pycxml track files * fix fortran warnings * edit track class * use single process * close netcdf files asap * make pycxml optional Co-authored-by: Kieran Ricardo <[email protected]> Co-authored-by: Kieran Ricardo <[email protected]>
gdal multi-threading for reprojection
Adds in a script to quickly downscale the wind multipliers and apply them to many wind fields quickly. If the wind multipliers have already been extracted this process takes minutes instead of weeks. Co-authored-by: Kieran Ricardo <[email protected]>
* BUGFIX: Fix autocorrelation function * Use mamba - Github actions environment build time was > 30 minutes * Swap scipy random for numpy version * Change order of modules - mamba build wanted gdal as first module in the list * Update test_maps.py - moving to matplotlib 3.3 seems to have changed the way segment data is represented in LinearSegmentedColormap instances
* Remove deprecated Basemap references * Update conda environment file * Update actions/checkout to v3, setup-miniconda to v2.2 * Leave shapely to dependencies * Remove cartopy version, bump python version * Stringify python version
* Remove deprecated Basemap references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing
shapefile.py
was based on an old version ofpyshp.shapefile
, but this causedcartopy
to use the older version of shapefile, which led toShapefileExceptions
when trying to plot maps.This bugfix removes the old
shapefile.py
from theUtilities
module and replaces references to that file with thepyshp
version.As
pyshp
is a dependency ofcartopy
, it is installed as part of the enviroment.