Fix PushDelegate instantiation in AndroidPushDelegateProvider #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 15, 2025 12:44
…r usage of FirebaseMessagingDelegate.
…or easier usage of FirebaseMessagingDelegate." This reverts commit 382a454.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal / 🛠 Implementation details
AndroidPushDelegateProviderwe are currently checking if the class name passed via the<meta-data android:value="io.getstream.android.push.PushDelegate">can be casted toAndroidPushDelegateProvider. This check will always fail, as the meta-data expects a class of typePushDelegate, which will then be instantiated via reflection by theAndroidPushDelgateProvider, and stored in thePushDelegateProvider.delegatesfield. In the PR, we now check if the class is of typePushDelegate, and then we instantiate it.