Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve which participant is shown in PiP, allow for mirroring the me video stream for better experience. #1185

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

aleksandar-apostolov
Copy link
Collaborator

🎯 Goal

The goal of this PR is to improve how PiP participant is determined and also improve the video rotation for me participant.

🛠 Implementation details

  1. PiP participant rules
  • If we have two participants only, always take the not-me one.
  • If we have a list of activeSpeakers find the first one who is not me
  • If we have a dominant speaker who is not me show it
  • If we currently have no other option, show me
  1. VideoConfig changes
  • The VideoRenderer now accepts a VideoRendererConfig which apart from the scale type and the fallback content also defines a parameter called mirrorStream if yes, the stream will be mirrored for a me participant in case the front camera is selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Picture in picture: I don't see other call participant, but only me Wrong video rotation in landscape mode
1 participant