Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve which participant is shown in PiP, allow for mirroring the me video stream for better experience. #1185

Merged
merged 6 commits into from
Sep 23, 2024
Merged

Improve which participant is shown in PiP, allow for mirroring the me video stream for better experience. #1185

merged 6 commits into from
Sep 23, 2024

Conversation

aleksandar-apostolov
Copy link
Collaborator

🎯 Goal

The goal of this PR is to improve how PiP participant is determined and also improve the video rotation for me participant.

🛠 Implementation details

  1. PiP participant rules
  • If we have two participants only, always take the not-me one.
  • If we have a list of activeSpeakers find the first one who is not me
  • If we have a dominant speaker who is not me show it
  • If we currently have no other option, show me
  1. VideoConfig changes
  • The VideoRenderer now accepts a VideoRendererConfig which apart from the scale type and the fallback content also defines a parameter called mirrorStream if yes, the stream will be mirrored for a me participant in case the front camera is selected.

@aleksandar-apostolov aleksandar-apostolov requested a review from a team as a code owner September 19, 2024 13:21
This was linked to issues Sep 19, 2024
Picture in picture: I don't see other call participant, but only me #1163
Closed
Wrong video rotation in landscape mode #1162
Closed
skydoves
skydoves approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me!

.../kotlin/io/getstream/video/android/compose/ui/components/video/config/VideoRendererConfig.kt Outdated Show resolved Hide resolved
@aleksandar-apostolov aleksandar-apostolov merged commit b7391b4 into develop Sep 23, 2024
6 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the pip_participant_choice_update branch September 23, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skydoves skydoves skydoves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Picture in picture: I don't see other call participant, but only me Wrong video rotation in landscape mode
2 participants
@aleksandar-apostolov @skydoves