-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve notifications #1183
Merged
aleksandar-apostolov
merged 9 commits into
develop
from
PBE-6042-fix-ongoing-notification-title
Sep 20, 2024
Merged
Improve notifications #1183
aleksandar-apostolov
merged 9 commits into
develop
from
PBE-6042-fix-ongoing-notification-title
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liviu-timar
changed the title
Improve ongoing call notification title/desc
Improve notifications
Sep 20, 2024
liviu-timar
force-pushed
the
PBE-6042-fix-ongoing-notification-title
branch
from
September 20, 2024 10:00
8be51e6
to
f163c62
Compare
liviu-timar
commented
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a bug. Pressing on the ongoing call Hang Up
button does not work on the caller device, only on receiver. Fixing it.
liviu-timar
commented
Sep 20, 2024
.../src/main/kotlin/io/getstream/video/android/core/notifications/DefaultNotificationHandler.kt
Show resolved
Hide resolved
...id-core/src/main/kotlin/io/getstream/video/android/core/notifications/NotificationHandler.kt
Outdated
Show resolved
Hide resolved
…on and getRingingCallNotification
aleksandar-apostolov
approved these changes
Sep 20, 2024
aleksandar-apostolov
deleted the
PBE-6042-fix-ongoing-notification-title
branch
September 20, 2024 13:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Refactor notifications to show up-to-date text and icons.
🛠 Implementation details
getOngoingCallNotification
method inNotificationHandler
with anonUpdate
lambda parameter.getOngoingCallNotification
observes the ringing state and number of members/participants and callsonUpdate
with a refreshed notification that reflects the call state.getOngoingCallNotification
is used inCallService
. Will also be used in theTelecom
implementation in the future.DefaultNotificationHandler
andCallService
callDisplayName
parameter inNotificationHandler#getRingingCallNotification()
is now nullable (String
->String?
).🎨 UI Changes
🧪 Testing