Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notifications #1183

Merged
merged 9 commits into from
Sep 20, 2024

Conversation

liviu-timar
Copy link
Member

@liviu-timar liviu-timar commented Sep 18, 2024

🎯 Goal

Refactor notifications to show up-to-date text and icons.

🛠 Implementation details

  • Added new getOngoingCallNotification method in NotificationHandler with an onUpdate lambda parameter.
  • The default implementation of getOngoingCallNotification observes the ringing state and number of members/participants and calls onUpdate with a refreshed notification that reflects the call state.
  • getOngoingCallNotification is used in CallService. Will also be used in the Telecom implementation in the future.
  • Various changes to DefaultNotificationHandler and CallService
  • Changed notification titles, desc, icons.
  • ❗ Breaking change: the callDisplayName parameter in NotificationHandler#getRingingCallNotification() is now nullable (String -> String?).

🎨 UI Changes

image

🧪 Testing

  • Go through the entire ringing flow and watch all notifications: incoming, outgoing, ongoing.
  • Start a group call and add/remove participants: incoming, outgoing, ongoing.

@liviu-timar liviu-timar marked this pull request as ready for review September 18, 2024 14:23
@liviu-timar liviu-timar requested a review from a team as a code owner September 18, 2024 14:23
@liviu-timar liviu-timar marked this pull request as draft September 18, 2024 14:23
@liviu-timar liviu-timar changed the title Improve ongoing call notification title/desc Improve notifications Sep 20, 2024
@liviu-timar liviu-timar force-pushed the PBE-6042-fix-ongoing-notification-title branch from 8be51e6 to f163c62 Compare September 20, 2024 10:00
@liviu-timar liviu-timar marked this pull request as ready for review September 20, 2024 10:04
Copy link
Member Author

@liviu-timar liviu-timar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a bug. Pressing on the ongoing call Hang Up button does not work on the caller device, only on receiver. Fixing it.

@aleksandar-apostolov aleksandar-apostolov merged commit 7a82213 into develop Sep 20, 2024
6 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the PBE-6042-fix-ongoing-notification-title branch September 20, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants