fix(llc): fixed foreground service being recreated when declining the…

… call (#764) * fixed foreground service recreation when declining the call * changelog
GetStream · Sep 18, 2024 · ba031c0 · ba031c0
1 parent 20a9aa2
commit ba031c0
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 1 deletion.
diff --git a/packages/stream_video/CHANGELOG.md b/packages/stream_video/CHANGELOG.md
@@ -1,5 +1,8 @@
 ## 0.5.4
 
+🐞 Fixed
+* Fixed an issue where active call foreground service was recreated after being stopped when ringing call was declined and in-app incoming screen was displayed.
+
 🚧 Breaking changes
 * The regular push notification handling has been removed from iOS, providing more control over the implementation. VoIP push notifications will continue to be handled as before. For more details, refer to the documentation.
 

diff --git a/packages/stream_video_flutter/CHANGELOG.md b/packages/stream_video_flutter/CHANGELOG.md
@@ -1,5 +1,8 @@
 ## 0.5.4
 
+🐞 Fixed
+* Fixed an issue where active call foreground service was recreated after being stopped when ringing call was declined and in-app incoming screen was displayed.
+
 🚧 Breaking changes
 * The regular push notification handling has been removed from iOS, providing more control over the implementation. VoIP push notifications will continue to be handled as before. For more details, refer to the documentation.
 

diff --git a/...src/main/kotlin/io/getstream/video/flutter/stream_video_flutter/service/ServiceManager.kt b/...src/main/kotlin/io/getstream/video/flutter/stream_video_flutter/service/ServiceManager.kt
@@ -84,7 +84,7 @@ class ServiceManagerImpl(
     }
 
     /**
-     * Start the foreground service.
+     * Stop the foreground service.
      */
     override fun stop(type: ServiceType): Boolean {
         logger.d { "[stop] type: $type" }

diff --git a/packages/stream_video_flutter/lib/src/call_background/background_service.dart b/packages/stream_video_flutter/lib/src/call_background/background_service.dart
@@ -238,6 +238,12 @@ class StreamBackgroundService {
     NotificationOptionsBuilder optionsBuilder,
   ) {
     return call.state.listen((value) async {
+      _logger.v(() => '[listenState] call service update, state: $value');
+
+      if (value.status is CallStatusDisconnected) {
+        return;
+      }
+
       try {
         final result = await StreamVideoFlutterBackground.updateService(
           NotificationPayload(

diff --git a/packages/stream_video_flutter/lib/stream_video_flutter_background.dart b/packages/stream_video_flutter/lib/stream_video_flutter_background.dart
@@ -34,6 +34,7 @@ mixin StreamVideoFlutterBackground {
     if (!isAndroid) {
       return false;
     }
+
     return StreamVideoFlutterPlatform.instance.updateBackgroundService(
       payload: options,
       type: type,