-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/diesel 2.0 #33
Feature/diesel 2.0 #33
Conversation
…der_giga_head_cherries Fix binary double byte order giga head cherries
This unblocks removing this function from diesel itself
This is the first step to support fully dynamic select queries in diesel-oci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will run the tests and report back.
src/oracle/connection/mod.rs
Outdated
begin | ||
create_if_not_exists('CREATE TABLE "__DIESEL_SCHEMA_MIGRATIONS" ( | ||
"VERSION" VARCHAR2(50) PRIMARY KEY NOT NULL, | ||
"RUN_ON" TIMESTAMP with time zone DEFAULT sysdate not null\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The \
probably needs to be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot even compile it:
Compiling r2d2 v0.8.7
error: cannot find macro `log!` in this scope
--> /home/paul/.cargo/registry/src/github.com-1ecc6299db9ec823/r2d2-0.8.7/src/lib.rs:121:9
|
121 | error!("{}", error);
| ^^^^^^^^^^^^^^^^^^^^
|
= note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
error: aborting due to previous error
error: Could not compile `r2d2`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the little stray backslash that Paul commented on, I think this looks good 👍
Updated branch that points to a recent diesel master branch with a few cherry picks, notably the following work in progress PR's are included:
Additionally some cleanup of the code base is done. I've removed unused files, simplified some things and improved the error handling in some places. Additionally this should unblock the usage of the dynamic querying feature sketched out here: diesel-rs/diesel-dynamic-schema#10.
Note: I've not run any tests yet, would be great if someone @giga-info could do that.