Make alias syntax configurable #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oracle does not support the `table AS alias` syntax for defining table aliases. Instead it requires the following syntax: `table alias`. This commit uses an updated diesel version that allows to customize the relevant `QueryFragment` impl and it provides a changed impl to fix the query.
MrMuetze
approved these changes
Aug 21, 2023
aleshaleksey
approved these changes
Aug 21, 2023
| @@ -52,3 +52,6 @@ chrono = ["chrono-time", "diesel/chrono"] | |||
| r2d2 = ["diesel/r2d2"] | |||
| dynamic-schema = ["diesel-dynamic-schema"] | |||
| gst = [] | |||
|
|
|||
| [patch.crates-io] | |||
There was a problem hiding this comment.
Of curiosity: I take it the patch is to use some unofficial pre-release version of diesel 2.1 with the latest trait changes and fixes? Or is there something more?
There was a problem hiding this comment.
- That diesel patch does only provide some additional ways to configure that specific syntax, the real fix happens in diesel-oci by using this flag + generating the right sql syntax. That happens mostly here: https://github.com/GiGainfosystems/diesel-oci/pull/51/files#diff-206a297303e4c39e996fa27af96fdcfd7d7075a4e42fc4597afe1cfbad835004R58-R70
- This patch is already merged upstream: Allow to configure the used alias syntax diesel-rs/diesel#3722, so it's not unoffical anymore. It's just not released, as this is strictly a new feature so it will be in diesel 2.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.