Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csharp: Update WeakPasswordHashing.qhelp #37

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Jan 8, 2024

In github/codeql#15122 I made a Swift version of the csharp weak password hashing query from this repo. This included adapting the .qhelp to Swift, in the process I (with input from @subatoi in the pull request) improved some parts of the doc. This PR backports these doc changes to the csharp version of the query.

Copy link
Contributor

@GeekMasher GeekMasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing @geoffw0

@geoffw0
Copy link
Contributor Author

geoffw0 commented Jan 8, 2024

Thanks for the approval. I don't see a merge button, possibly I don't have permission to merge in this repo.

@GeekMasher GeekMasher merged commit 450046b into GitHubSecurityLab:main Jan 8, 2024
11 checks passed
@GeekMasher
Copy link
Contributor

Oh sorry, I'll merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants