Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added requestWrap and sendReady #670

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

redzovic
Copy link

@redzovic redzovic commented Oct 8, 2024

The user can await requestWrap until the Endpoint calls sendReady.

This is a proposed solution to the problems mentioned in #665 and #635.

It does not break the previous wrap or expose function signature but rather adds the two optional functions requestWrap() and sendReady() which can be used to avoid deadlocks.

Here is an example on how to use the proposed changes in actual code:
main.ts

import * as Comlink from "comlink";

let worker = new Worker(new URL("./extension", import.meta.url), { type: "module" });
let api = await Comlink.requestWrap(worker);

await api.hey();

extension.ts

import * as Comlink from "comlink";

Comlink.expose(
  {
    str: "exposed string",
    hey() { console.log("helloo!") },
  });

Comlink.sendReady(self);

Copy link

google-cla bot commented Oct 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant